Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify that after rolling back a transaction the exception gets thrown again #1266

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

twiddler
Copy link
Contributor

I needed to know whether I can try … catch … exceptions that are thrown in the callback to db.transcation().execute(…) or whether they get swallowed. The docs are not clear about this.

I added a few words to the docs to clarify. (This is the relevant code.)

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2024 0:31am

Copy link

pkg-pr-new bot commented Nov 18, 2024

Open in Stackblitzkysely_koa_example

npm i https://pkg.pr.new/kysely-org/kysely@1266

commit: 8eadf8b

Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

LGTM! 🚀

@igalklebanov igalklebanov added the documentation Improvements or additions to documentation label Nov 24, 2024
@igalklebanov igalklebanov merged commit 7a69903 into kysely-org:master Nov 24, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants